Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that StringComparers and StringComparisons are kept in sync #9527

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

drewnoakes
Copy link
Member

@drewnoakes drewnoakes commented Aug 25, 2024

These two utility classes should have the same members, with equivalent values. This change adds missing properties to both classes, and adds a test to ensure that they're kept in sync in future.

(I made a similar test for Aspire so copied it here.)

Microsoft Reviewers: Open in CodeFlow

These two utility classes should have the same members, with equivalent values. This change adds missing properties to both classes, and adds a test to ensure that they're kept in sync in future.
@drewnoakes drewnoakes added the Area-Testing Relates to testing and does not affect product code. label Aug 25, 2024
@drewnoakes drewnoakes requested a review from a team as a code owner August 25, 2024 23:48
@adamint
Copy link
Member

adamint commented Aug 27, 2024

These two utility classes should have the same members, with equivalent values

Why do we not use a generator currently?

@drewnoakes
Copy link
Member Author

I'm not aware of a generator that would do this in a simple way.

@drewnoakes drewnoakes merged commit be5d271 into dotnet:main Aug 28, 2024
5 checks passed
@drewnoakes drewnoakes deleted the string-comparers-sync-test branch August 28, 2024 23:37
@dotnet-policy-service dotnet-policy-service bot added this to the 17.12 milestone Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Testing Relates to testing and does not affect product code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants